Skip to content

🐛 Fix TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType' #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

🐛 Fix TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType' #2229

merged 1 commit into from
Apr 30, 2025

Conversation

@shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Apr 29, 2025

Fixes

Fixes

C-PAC failed to start
Traceback (most recent call last):
  File "/code/CPAC/pipeline/cpac_runner.py", line 653, in run
    exitcode = run_workflow(
  File "/code/CPAC/pipeline/cpac_pipeline.py", line 806, in run_workflow
    resource_report(cb_log_filename, num_cores_per_sub, WFLOGGER)
  File "/code/CPAC/utils/monitoring/draw_gantt_chart.py", line 592, in resource_report
    generate_gantt_chart(callback_log, num_cores)
  File "/code/CPAC/utils/monitoring/draw_gantt_chart.py", line 405, in generate_gantt_chart
    node["duration"] = (node["finish"] - node["start"]).total_seconds()
TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'

Description

I noticed 1.8.8.dev runs having fake-out failedToStart.logs with the above error, trying to set durations on nodes that hadn't yet started.

Technical details

Checks that there's a start and a finish before setting a duration.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added bug develop issue on `develop` branch labels Apr 29, 2025
@shnizzedy shnizzedy added this to the 1.8.8 release milestone Apr 29, 2025
@shnizzedy shnizzedy requested a review from a team April 29, 2025 17:27
@shnizzedy shnizzedy self-assigned this Apr 29, 2025
@shnizzedy shnizzedy moved this to 👀 In review in C-PAC Development Apr 29, 2025
birajstha
birajstha approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@birajstha birajstha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊, I guess this one fixes CPAC stalling with 0/ running.
I had seen few of them in my runs with 1.8.8 too.

@shnizzedy
Copy link
Member Author

shnizzedy commented Apr 30, 2025

I guess this one fixes CPAC stalling with 0/ running.

I don't think these were actually failing to start; I think they were just incorrectly logging that they were failing to start

@shnizzedy shnizzedy merged commit f21d5a4 into develop Apr 30, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in C-PAC Development Apr 30, 2025
@shnizzedy shnizzedy deleted the fix/duration branch April 30, 2025 17:01
shnizzedy added a commit that referenced this pull request May 13, 2025
@shnizzedy
fixup! 🐛 Fix `TypeError: unsupported operand type(s) for -: 'NoneType…
81d0b6e 
…' and 'NoneType'` (#2229)
shnizzedy added a commit that referenced this pull request May 19, 2025
@shnizzedy
fixup! fixup! 🐛 Fix `TypeError: unsupported operand type(s) for -: 'N…
17e68b7 
…oneType' and 'NoneType'` (#2229)
@shnizzedy shnizzedy mentioned this pull request May 21, 2025
Merged
8 tasks
@shnizzedy shnizzedy mentioned this pull request Jun 18, 2025
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birajstha birajstha birajstha approved these changes

Assignees

@shnizzedy shnizzedy

Labels

bug develop issue on `develop` branch

Projects

C-PAC Development
Status: ✅ Done

Milestone

1.8.8 release

Development

Successfully merging this pull request may close these issues.

3 participants

@shnizzedy @birajstha